Would be interesting to see the performance difference if you undo that move-&-c... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

		is_taken on Nov 14, 2022 \| parent \| context \| favorite \| on: Making a Go program faster with a one-character ch... Would be interesting to see the performance difference if you undo that move-&-change and change the function signature from: `func (r Ruleset) Match(path string) (Rule, error)` to: `func (r Ruleset) Match(path string) (*Rule, error)`

masklinn on Nov 14, 2022 [–]

Likely none: Ruleset is

    type Ruleset []Rule

The original code creates a local copy of a rule and explicitly returns a pointer to that. Taking the ruleset by address wouldn't change that issue.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact