> but what's the bright line between what he does and what a patent troll does?

He actually does something with his patents, he develops profucts and then licenses the manufacturing.

Patents trolls don't do anything useful. They buy the patents (most of which are trivial and obvious), and then they wait for somebody to implement said trivial and obvious.